packages/client/src/helpers/RNSpeechDetector.ts (1)

20-70: ⚠️ Potential issue | 🟠 Major

Ensure partial start() failures run full cleanup.

If any step throws after Line 43 listener registration or after Line 56 subscription setup, the catch block (Line 66) only logs and returns a noop, leaving resources/listeners active.

Proposed fix

 public async start(onSoundDetectedStateChanged: SoundStateChangeHandler) {
+  let onPc1IceCandidate:
+    | ((e: RTCPeerConnectionIceEvent) => void)
+    | undefined;
+  let onPc2IceCandidate:
+    | ((e: RTCPeerConnectionIceEvent) => void)
+    | undefined;
+  let onTrackPc2: ((e: RTCTrackEvent) => void) | undefined;
+  let unsubscribe: (() => void) | undefined;
   try {
     this.isStopped = false;
@@
-    const onPc1IceCandidate = (e: RTCPeerConnectionIceEvent) => {
+    onPc1IceCandidate = (e: RTCPeerConnectionIceEvent) => {
       this.forwardIceCandidate(this.pc2, e.candidate);
     };
-    const onPc2IceCandidate = (e: RTCPeerConnectionIceEvent) => {
+    onPc2IceCandidate = (e: RTCPeerConnectionIceEvent) => {
       this.forwardIceCandidate(this.pc1, e.candidate);
     };
-    const onTrackPc2 = (e: RTCTrackEvent) => {
+    onTrackPc2 = (e: RTCTrackEvent) => {
@@
-    const unsubscribe = this.onSpeakingDetectedStateChange(
+    unsubscribe = this.onSpeakingDetectedStateChange(
       onSoundDetectedStateChanged,
     );
     return () => {
@@
   } catch (error) {
+    if (onPc1IceCandidate) {
+      this.pc1.removeEventListener('icecandidate', onPc1IceCandidate);
+    }
+    if (onPc2IceCandidate) {
+      this.pc2.removeEventListener('icecandidate', onPc2IceCandidate);
+    }
+    if (onTrackPc2) {
+      this.pc2.removeEventListener('track', onTrackPc2);
+    }
+    unsubscribe?.();
+    this.stop();
     const logger = videoLoggerSystem.getLogger('RNSpeechDetector');
     logger.error('error handling permissions: ', error);
     return () => {};
   }
 }

As per coding guidelines: "Unregister event listeners in cleanup/disposal code to prevent memory leaks".

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/client/src/helpers/RNSpeechDetector.ts` around lines 20 - 70, The
try block can throw after listeners (onPc1IceCandidate, onPc2IceCandidate,
onTrackPc2) and after subscription (unsubscribe) are created, but the catch only
logs and returns a noop leaving listeners, tracks and peers active; add a
deterministic cleanup path and call it from the catch (or use finally).
Implement a local cleanup routine inside start() that removes the three
listeners from this.pc1/this.pc2, calls unsubscribe() if it was set, stops and
nulls audioStream tracks, and calls this.stop() / closes pc1/pc2 as appropriate,
then invoke that cleanup from the catch so partial failures free resources and
prevent leaks.